Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 29843004: Allow all events to be accessed via on[foo] instead of just onFoo (Closed)

Created:
7 years, 2 months ago by Emily Fortuna
Modified:
7 years, 2 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow all events to be accessed via on[foo] instead of just onFoo BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=28966

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -4 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +24 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_EventTarget.darttemplate View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Emily Fortuna
No tests, because these test things like Mouse Pointer Lock, and Speech and fullscreen. :-P ...
7 years, 2 months ago (2013-10-19 00:57:31 UTC) #1
blois
https://codereview.chromium.org/29843004/diff/1/tools/dom/templates/html/impl/impl_EventTarget.darttemplate File tools/dom/templates/html/impl/impl_EventTarget.darttemplate (right): https://codereview.chromium.org/29843004/diff/1/tools/dom/templates/html/impl/impl_EventTarget.darttemplate#newcode58 tools/dom/templates/html/impl/impl_EventTarget.darttemplate:58: 'fullscreenchange' : 'onwebkitfullscreenchange', the on prefix should not be ...
7 years, 2 months ago (2013-10-19 01:19:09 UTC) #2
Emily Fortuna
ptal https://codereview.chromium.org/29843004/diff/1/tools/dom/templates/html/impl/impl_EventTarget.darttemplate File tools/dom/templates/html/impl/impl_EventTarget.darttemplate (right): https://codereview.chromium.org/29843004/diff/1/tools/dom/templates/html/impl/impl_EventTarget.darttemplate#newcode58 tools/dom/templates/html/impl/impl_EventTarget.darttemplate:58: 'fullscreenchange' : 'onwebkitfullscreenchange', On 2013/10/19 01:19:10, blois wrote: ...
7 years, 2 months ago (2013-10-21 17:43:51 UTC) #3
blois
https://codereview.chromium.org/29843004/diff/60001/tools/dom/templates/html/impl/impl_EventTarget.darttemplate File tools/dom/templates/html/impl/impl_EventTarget.darttemplate (right): https://codereview.chromium.org/29843004/diff/60001/tools/dom/templates/html/impl/impl_EventTarget.darttemplate#newcode77 tools/dom/templates/html/impl/impl_EventTarget.darttemplate:77: if (type.toLowerCase() in webkitEvents.keys) { types are case-sensitive, toLowerCase ...
7 years, 2 months ago (2013-10-21 22:57:58 UTC) #4
blois
lgtm
7 years, 2 months ago (2013-10-21 23:02:28 UTC) #5
Emily Fortuna
7 years, 2 months ago (2013-10-21 23:07:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r28966 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698