Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 29823003: Add test for type variable ownership. (Closed)

Created:
7 years, 2 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
zarah, gbracha
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/type_variable_owner_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
7 years, 2 months ago (2013-10-18 21:55:59 UTC) #1
gbracha
lgtm
7 years, 2 months ago (2013-10-18 22:40:41 UTC) #2
zarah
LGTM!
7 years, 2 months ago (2013-10-20 05:23:20 UTC) #3
rmacnak
7 years, 2 months ago (2013-10-21 16:56:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r28936 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698