Issue 298203002: Make compile-time constants in _IntegerImplementation.compareTo const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 298203002: Make compile-time constants in _IntegerImplementation.compareTo const. (Closed)

Created:
6 years, 7 months ago by Florian Schneider

Modified:
6 years, 6 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Make compile-time constants in _IntegerImplementation.compareTo const. Committed: https://code.google.com/p/dart/source/detail?r=36864

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	runtime/lib/integers.dart	View		1 chunk	+3 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Florian Schneider

Randomly stumbled over this TODO. What was the reason for it? It seems const works ...

6 years, 7 months ago (2014-05-27 11:38:28 UTC) #1

Florian Schneider

6 years, 6 months ago (2014-06-02 11:10:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r36864 (presubmit successful).