Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2979043002: Migrate tests to using package test (Closed)

Created:
3 years, 5 months ago by keertip
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : revert format changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/int32_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M test/int64_test.dart View 1 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
keertip
3 years, 5 months ago (2017-07-14 20:08:49 UTC) #2
Bob Nystrom
LGTM! :D
3 years, 5 months ago (2017-07-14 20:21:02 UTC) #3
keertip
3 years, 5 months ago (2017-07-14 20:39:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
12720ee55757f022a9c4552ceb4683c003647344 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698