Issue 297873002: Append to flaky log on second run with optimization thresshold counter on pub bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297873002: Append to flaky log on second run with optimization thresshold counter on pub bots. (Closed)

Created:
6 years, 7 months ago by ricow1

Modified:
6 years, 7 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Append to flaky log on second run with optimization thresshold counter on pub bots. Remove looping over the options array R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=36477

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	tools/bots/pub.py	View	1 2 3	1 chunk	+14 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

lgtm https://codereview.chromium.org/297873002/diff/20001/tools/bots/pub.py File tools/bots/pub.py (right): https://codereview.chromium.org/297873002/diff/20001/tools/bots/pub.py#newcode55 tools/bots/pub.py:55: bot.RunTest('pub and pkg optimization counter thresshold 5', build_info, ...

6 years, 7 months ago (2014-05-22 09:26:42 UTC) #2

ricow1

https://codereview.chromium.org/297873002/diff/20001/tools/bots/pub.py File tools/bots/pub.py (right): https://codereview.chromium.org/297873002/diff/20001/tools/bots/pub.py#newcode55 tools/bots/pub.py:55: bot.RunTest('pub and pkg optimization counter thresshold 5', build_info, On ...

6 years, 7 months ago (2014-05-22 09:27:15 UTC) #3

ricow1

6 years, 7 months ago (2014-05-22 09:27:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r36477 (presubmit successful).

Expand Messages | Collapse Messages