Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 297653003: Fix websocket status-code for when the close-timer or error cases. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
ricow1, Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix websocket status-code for when the close-timer or error cases. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=36346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M sdk/lib/io/websocket_impl.dart View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 7 months ago (2014-05-20 07:37:46 UTC) #1
ricow1
lgtm
6 years, 7 months ago (2014-05-20 07:39:31 UTC) #2
Anders Johnsen
6 years, 7 months ago (2014-05-20 07:49:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36346 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698