Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 297413002: Ensure that failure to start an isolate all end up in the future. (Closed)

Created:
6 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Søren Gjesse, floitsch
Visibility:
Public.

Description

Ensure that failure to start an isolate all end up in the future. Isolate.spawnUri can fail in many ways. Any problem that prevents calling "main" on a loaded isolate should end up as IsolateSpawnException in the future returned by Isolate.spawnUri. This CL ensures that failure to look up main is handled correctly, and adds more tests. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=36982

Patch Set 1 #

Patch Set 2 : Make test file be named *_test.dart #

Total comments: 1

Patch Set 3 : Update status fules #

Patch Set 4 : Don't need to pretend imports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -63 lines) Patch
M runtime/lib/isolate_patch.dart View 1 2 2 chunks +26 lines, -8 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 2 chunks +17 lines, -7 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
A + tests/isolate/isolate_create_error_helper_echo.dart View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
A + tests/isolate/isolate_create_error_helper_lib.dart View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
A + tests/isolate/isolate_create_error_helper_lib2.dart View 1 chunk +4 lines, -6 lines 0 comments Download
A + tests/isolate/isolate_create_error_helper_lib3.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + tests/isolate/isolate_create_error_helper_lib4.dart View 1 chunk +4 lines, -7 lines 0 comments Download
A + tests/isolate/isolate_create_error_helper_lib5.dart View 1 chunk +5 lines, -14 lines 0 comments Download
A + tests/isolate/isolate_create_error_helper_syntax_error.dart View 1 chunk +5 lines, -8 lines 0 comments Download
A tests/isolate/isolate_create_error_test.dart View 1 2 3 1 chunk +161 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein Nielsen
6 years, 7 months ago (2014-05-26 12:58:30 UTC) #1
Lasse Reichstein Nielsen
PTAL
6 years, 7 months ago (2014-05-28 09:10:41 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/297413002/diff/20001/tests/isolate/isolate_create_error_test.dart File tests/isolate/isolate_create_error_test.dart (right): https://codereview.chromium.org/297413002/diff/20001/tests/isolate/isolate_create_error_test.dart#newcode35 tests/isolate/isolate_create_error_test.dart:35: result.then(badSuccess, onError: (IsolateSpawnException e) { Add an expectation ...
6 years, 6 months ago (2014-05-28 12:00:41 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #4 manually as r36982 (presubmit successful).
6 years, 6 months ago (2014-06-04 08:42:52 UTC) #4
Lasse Reichstein Nielsen
6 years, 6 months ago (2014-06-04 10:01:24 UTC) #5
Reverted. Some tests fails on the bot that don't fail locally.

Powered by Google App Engine
This is Rietveld 408576698