Issue 297303010: Add watch and modify/delete support to MemoryFile.

Issue 297303010: Add watch and modify/delete support to MemoryFile. (Closed)

Created:
6 years, 6 months ago by Paul Berry

Modified:
6 years, 6 months ago

Reviewers:
scheglov, danrubel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add watch and modify/delete support to MemoryFile. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=36762

Patch Set 1 #

Total comments: 6

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -2 lines)			Patch
	M	pkg/analysis_server/lib/src/resource.dart	View		3 chunks	+45 lines, -2 lines	6 comments	Download
	M	pkg/analysis_server/test/resource_test.dart	View		3 chunks	+140 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

lgtm https://codereview.chromium.org/297303010/diff/1/pkg/analysis_server/lib/src/resource.dart File pkg/analysis_server/lib/src/resource.dart (right): https://codereview.chromium.org/297303010/diff/1/pkg/analysis_server/lib/src/resource.dart#newcode252 pkg/analysis_server/lib/src/resource.dart:252: var streamController = new StreamController<WatchEvent>(); AFAIK we use ...

6 years, 6 months ago (2014-05-28 18:22:27 UTC) #2

Paul Berry

Committed patchset #1 manually as r36762 (presubmit successful).

6 years, 6 months ago (2014-05-28 20:16:02 UTC) #3

Paul Berry

6 years, 6 months ago (2014-05-28 20:16:22 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/297303010/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/resource.dart (right):

https://codereview.chromium.org/297303010/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/resource.dart:252: var streamController = new
StreamController<WatchEvent>();
On 2014/05/28 18:22:28, scheglov wrote:
> AFAIK we use type annotations.

Done.

https://codereview.chromium.org/297303010/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/resource.dart:324: void _notifyWatchers(String path,
changeType) {
On 2014/05/28 18:22:28, scheglov wrote:
> Type annotation for "changeType".

Done.

https://codereview.chromium.org/297303010/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/resource.dart:325:
_pathToWatcher.forEach((watcherPath, streamController) {
On 2014/05/28 18:22:28, scheglov wrote:
> I'm not 100% sure, but AFAIK we should put type annotation here too.

Done.

Expand Messages | Collapse Messages