Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 297213005: Add Socket ref to HttpServer. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Deploy #

Patch Set 3 : Deploy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2307 lines, -974 lines) Patch
M runtime/bin/service_object_patch.dart View 1 2 2 chunks +18 lines, -1 line 0 comments Download
M runtime/bin/socket_patch.dart View 8 chunks +34 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 4 chunks +501 lines, -9 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 2 160 chunks +563 lines, -467 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 4 chunks +501 lines, -9 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 160 chunks +563 lines, -467 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/io_view.html View 1 2 3 chunks +47 lines, -7 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/io_view.dart View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/io_view.html View 1 2 3 chunks +47 lines, -7 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_view.dart View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 7 months ago (2014-05-26 13:13:06 UTC) #1
Cutch
lgtm
6 years, 7 months ago (2014-05-26 14:53:58 UTC) #2
Anders Johnsen
6 years, 7 months ago (2014-05-27 06:38:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r36644 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698