pkg/http_base: starting alignment with http and shelf

pkg/http_base: starting alignment with http and shelf

R=kustermann@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37344

[kevmoo, 2014-05-27 03:38:38]

Until we have a user of the server type, let's drop it. It only introduces
confusion.

Changed the doc comments, too. We've standardized on /// across most of pkg –
and for all new code

It's always 2 lines shorter than the /***/ syntax.

[kustermann, 2014-05-27 07:26:02]

I'll leave the decision to Soeren.


> Until we have a user of the server type, let's drop it. It only introduces
> confusion.

Why should a user confuse a "Client" with a "RequestHandler"?

If everything works out, it could be that you'll have the first user of this by
the end of next week.

> Changed the doc comments, too. We've standardized on /// across most of pkg –
> and for all new code

I cannot confirm that the /// syntax is used everywhere in dart/pkg and our core
libraries don't use it much I think. Why did we start using /// in the first
place -- i.e. why did we start fragmenting?
I think we should be consistent across core libraries, packages and user
recommendations.


> It's always 2 lines shorter than the /***/ syntax.

That is not the best argument. There are pros and cons of both ways, but:

[Søren Gjesse, 2014-05-27 09:05:51]

On 2014/05/27 03:38:38, kevmoo wrote:
> Until we have a user of the server type, let's drop it. It only introduces
> confusion.
> 
> Changed the doc comments, too. We've standardized on /// across most of pkg –
> and for all new code
> 
> It's always 2 lines shorter than the /***/ syntax.

We will use the server type for testing the discovery APIs (providing a mock
implementation of the service).

Regarding the comments feel free to change it to ///. Personally I like the
"longer" syntax better, but I am OK with the /// one.

lgtm for the comment syntax.

[kevmoo, 2014-06-13 17:20:20]

PTAL

[kustermann, 2014-06-15 09:26:44]

LGTM

[kevmoo, 2014-06-15 18:41:21]

Committed patchset #3 manually as r37344 (presubmit successful).