Issue 297033002: Add Result.flatten.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297033002: Add Result.flatten. (Closed)

Created:
6 years, 7 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add Result.flatten. Update version to 1.0.0 Fix typo in Result doc forgotten in previous CL. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=36556

Patch Set 2 : Making factory properly factory. #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -3 lines)			Patch
M	pkg/async/lib/result.dart	View	1	3 chunks	+15 lines, -2 lines	0 comments	Download
M	pkg/async/pubspec.yaml	View		1 chunk	+1 line, -1 line	1 comment	Download
M	pkg/async/test/result_test.dart	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/297033002/diff/20001/pkg/async/pubspec.yaml File pkg/async/pubspec.yaml (right): https://codereview.chromium.org/297033002/diff/20001/pkg/async/pubspec.yaml#newcode2 pkg/async/pubspec.yaml:2: version: 1.0.0 Great!

6 years, 7 months ago (2014-05-23 09:45:56 UTC) #2

Lasse Reichstein Nielsen

6 years, 7 months ago (2014-05-23 09:53:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r36556 (presubmit successful).

Expand Messages | Collapse Messages

Issue 297033002: Add Result.flatten. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Making factory properly factory. #

Messages