Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 296853002: Fix code invalidation of functions with references to deferred libraries (Closed)

Created:
6 years, 7 months ago by hausner
Modified:
6 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider
Visibility:
Public.

Description

Fix code invalidation of functions with references to deferred libraries When a code object with a reference to a deferred library prefix is invalidated, it must be removed from the function object, and also patched so that direct calls to it (from optimized code for example) will trap and redirect to the newly compiled code. Removing an overly eager assertion. This fixes bug 18909. R=fschneider@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36436

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M runtime/vm/code_generator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
6 years, 7 months ago (2014-05-20 23:45:37 UTC) #1
srdjan
lgtm
6 years, 7 months ago (2014-05-21 05:56:08 UTC) #2
Florian Schneider
LGTM
6 years, 7 months ago (2014-05-21 06:52:36 UTC) #3
hausner
6 years, 7 months ago (2014-05-21 16:06:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r36436 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698