Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 296733002: Change expectation for jsshell on lib/async/timer_isolate_test. (Closed)

Created:
6 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 7 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change expectation for jsshell on lib/async/timer_isolate_test. An uncaught error in an isolate does not cause the program to exit. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=36351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/lib/lib.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
6 years, 7 months ago (2014-05-20 09:12:24 UTC) #1
Bill Hesse
lgtm
6 years, 7 months ago (2014-05-20 09:13:33 UTC) #2
Lasse Reichstein Nielsen
6 years, 7 months ago (2014-05-20 11:33:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36351 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698