Issue 296713005: Do not Dart_RunLoop if --load_async=false. This allows the program to run to the end with --pause-i…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296713005: Do not Dart_RunLoop if --load_async=false. This allows the program to run to the end with --pause-i… (Closed)

Created:
6 years, 7 months ago by srdjan

Modified:
6 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Do not Dart_RunLoop if --load_async=false. This allows the program to run to the end with --pause-isolates-on-exit --load-async=false. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=36595

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	runtime/bin/main.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

hausner

LGTM. This is essentially a bandaid solution. We need a better way to instruct the ...

6 years, 7 months ago (2014-05-23 22:33:56 UTC) #2

srdjan

6 years, 7 months ago (2014-05-23 22:37:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r36595 (presubmit successful).