Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 296513015: Revert "Handle metadata on nested function parameters." (Closed)

Created:
6 years, 7 months ago by Johnni Winther
Modified:
6 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -130 lines) Patch
M sdk/lib/_internal/compiler/implementation/deferred_load.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 4 chunks +6 lines, -13 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 11 chunks +8 lines, -17 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart View 2 chunks +9 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 7 chunks +22 lines, -31 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +2 lines, -0 lines 0 comments Download
D tests/language/metadata_scope1_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/language/metadata_scope2_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/language/metadata_self_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D tests/language/parameter_metadata_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
TBR
6 years, 7 months ago (2014-05-22 12:25:36 UTC) #1
karlklose
LGTM.
6 years, 7 months ago (2014-05-22 12:28:41 UTC) #2
Johnni Winther
6 years, 7 months ago (2014-05-22 12:30:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36489 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698