Handle metadata on nested function parameters.

Handle metadata on nested function parameters.

BUG=http://dartbug.com/16281
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36485

Committed: https://code.google.com/p/dart/source/detail?r=36547

Committed: https://code.google.com/p/dart/source/detail?r=36653

[karlklose, 2014-05-22 06:27:29]

LGTM.

https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right):

https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:401: Element
get analyzableElement;
Perhaps we should have have AstElement extend AnalyzableElement and make
AnalyzeableElement part of the members interface.

Add a TODO to make this return an AnalyzabelElement.

https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:203: Element get
outermostEnclosingMemberOrTopLevel {
Add a TODO to remove this helper or give it a better name (or at least a comment
answering lrn's question?

https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1201:
assert(invariant(node, context is AnalyzableElement,
You could remove this, if the getter was typed () -> AnalyzableElement.

[Johnni Winther, 2014-05-22 10:09:08]

PTAL

https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right):

https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:401: Element
get analyzableElement;
On 2014/05/22 06:27:29, karlklose wrote:
> Perhaps we should have have AstElement extend AnalyzableElement and make
> AnalyzeableElement part of the members interface.
> 
> Add a TODO to make this return an AnalyzabelElement.

Added AnalyzableElement as an interface.

https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:203: Element get
outermostEnclosingMemberOrTopLevel {
On 2014/05/22 06:27:29, karlklose wrote:
> Add a TODO to remove this helper or give it a better name (or at least a
comment
> answering lrn's question?

Done.

https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1201:
assert(invariant(node, context is AnalyzableElement,
On 2014/05/22 06:27:29, karlklose wrote:
> You could remove this, if the getter was typed () -> AnalyzableElement.

Done.

[karlklose, 2014-05-22 10:33:44]

On 2014/05/22 10:09:08, Johnni Winther wrote:
> PTAL
> 
>
https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
> File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right):
> 
>
https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
> sdk/lib/_internal/compiler/implementation/elements/elements.dart:401: Element
> get analyzableElement;
> On 2014/05/22 06:27:29, karlklose wrote:
> > Perhaps we should have have AstElement extend AnalyzableElement and make
> > AnalyzeableElement part of the members interface.
> > 
> > Add a TODO to make this return an AnalyzabelElement.
> 
> Added AnalyzableElement as an interface.
> 
>
https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
> File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):
> 
>
https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
> sdk/lib/_internal/compiler/implementation/elements/modelx.dart:203: Element
get
> outermostEnclosingMemberOrTopLevel {
> On 2014/05/22 06:27:29, karlklose wrote:
> > Add a TODO to remove this helper or give it a better name (or at least a
> comment
> > answering lrn's question?
> 
> Done.
> 
>
https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
> File sdk/lib/_internal/compiler/implementation/resolution/members.dart
(right):
> 
>
https://codereview.chromium.org/296463003/diff/10001/sdk/lib/_internal/compil...
> sdk/lib/_internal/compiler/implementation/resolution/members.dart:1201:
> assert(invariant(node, context is AnalyzableElement,
> On 2014/05/22 06:27:29, karlklose wrote:
> > You could remove this, if the getter was typed () -> AnalyzableElement.
> 
> Done.

SLGTM.

[Johnni Winther, 2014-05-22 11:21:14]

Committed patchset #3 manually as r36485 (presubmit successful).

[Johnni Winther, 2014-05-23 07:55:56]

TBR

https://codereview.chromium.org/296463003/diff/70001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/296463003/diff/70001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1032: bool get
isResolved => hasTreeElements;
The [TreeElements] can be created from resolution metadata on the typedef.

[Johnni Winther, 2014-05-23 08:31:11]

Committed patchset #5 manually as r36547 (presubmit successful).

[karlklose, 2014-05-26 07:45:57]

On 2014/05/23 08:31:11, Johnni Winther wrote:
> Committed patchset #5 manually as r36547 (presubmit successful).

LGTM.

[Johnni Winther, 2014-05-26 13:04:26]

PTAL at the last patch.

[karlklose, 2014-05-27 07:52:46]

LGTM.

https://codereview.chromium.org/296463003/diff/130001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/296463003/diff/130001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1797:
typdef.ensureResolved(compiler);
Add a TODO that resolution should imply that the type is resolved (also for
classes).

[Johnni Winther, 2014-05-27 08:30:13]

Committed patchset #8 manually as r36653 (presubmit successful).

[Johnni Winther, 2014-05-27 08:43:31]

https://codereview.chromium.org/296463003/diff/130001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/296463003/diff/130001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1797:
typdef.ensureResolved(compiler);
On 2014/05/27 07:52:46, karlklose wrote:
> Add a TODO that resolution should imply that the type is resolved (also for
> classes).

Done.