Issue 296453013: Fix bug with optimized try-catch and unboxed values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296453013: Fix bug with optimized try-catch and unboxed values. (Closed)

Created:
6 years, 7 months ago by Florian Schneider

Modified:
6 years, 7 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug with optimized try-catch and unboxed values. The environment at calls inside try-blocs must only contain tagged values. Therefore we can't eliminate boxing instructions that are used in environments. Since we only generate boxing instructions for environment uses inside try-blocks there are no performance implications otherwise (outside try-blocks). R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36472

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -4 lines)			Patch
	M	runtime/vm/intermediate_language.cc	View	1	4 chunks	+16 lines, -4 lines	0 comments	Download
	A	tests/language/try_catch_optimized3_test.dart	View		1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

6 years, 7 months ago (2014-05-22 08:25:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r36472 (presubmit successful).

Expand Messages | Collapse Messages