Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 296403005: Show actualy FD for files in Observatory. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Show actualy FD for files in Observatory. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36656

Patch Set 1 #

Patch Set 2 : Add dart2js patch function. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M runtime/bin/builtin_natives.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/file.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/file.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/bin/file_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/file_linux.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/file_patch.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/file_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/io_patch.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 7 months ago (2014-05-27 08:35:54 UTC) #1
Cutch
lgtm
6 years, 7 months ago (2014-05-27 08:45:34 UTC) #2
Anders Johnsen
6 years, 7 months ago (2014-05-27 09:18:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r36656 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698