Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 296193008: Generate proper override warnings when conflicting members are inherited. (Closed)

Created:
6 years, 7 months ago by Paul Berry
Modified:
6 years, 6 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Generate proper override warnings when conflicting members are inherited. BUG=dartbug.com/16135 dartbug.com/17983 R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=36690

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 7 months ago (2014-05-23 21:12:32 UTC) #1
jwren
On 2014/05/23 21:12:32, Paul Berry wrote: LGTM
6 years, 7 months ago (2014-05-23 21:34:39 UTC) #2
Paul Berry
6 years, 6 months ago (2014-05-27 15:57:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36690 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698