Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 296153012: Update pub test status (Closed)

Created:
6 years, 7 months ago by hausner
Modified:
6 years, 7 months ago
Reviewers:
Bob Nystrom, nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update pub test status Some tests expect a very specific error message format when they check for load errors. My recent change for async loading of sources changed the message. Mark some tests as failing until the error msg expectations have been relaxed. TBR=rnystrom Committed: https://code.google.com/p/dart/source/detail?r=36580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M sdk/lib/_internal/pub/pub.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
6 years, 7 months ago (2014-05-23 18:37:31 UTC) #1
hausner
Committed patchset #1 manually as r36580 (presubmit successful).
6 years, 7 months ago (2014-05-23 18:37:43 UTC) #2
nweiz
For future reference, please include a bug number with status file changes like this so ...
6 years, 7 months ago (2014-05-23 23:00:50 UTC) #3
Bob Nystrom
6 years, 7 months ago (2014-05-27 16:18:36 UTC) #4
Message was sent while issue was closed.
Just to close the thread here, LGTM.

Powered by Google App Engine
This is Rietveld 408576698