Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 296043003: Fix for issue 14527 (Closed)

Created:
6 years, 7 months ago by Brian Wilkerson
Modified:
6 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add more tests #

Messages

Total messages: 4 (0 generated)
Brian Wilkerson
6 years, 7 months ago (2014-05-20 16:03:22 UTC) #1
Brian Wilkerson
PTAL I added more tests, but I was mistaken: the code you asked about is ...
6 years, 7 months ago (2014-05-20 17:37:19 UTC) #2
scheglov
LGTM
6 years, 7 months ago (2014-05-20 17:58:52 UTC) #3
Brian Wilkerson
6 years, 7 months ago (2014-05-20 18:19:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r36371 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698