Issue 29603004: Revise the barback transformer-finding logic slightly.

Issue 29603004: Revise the barback transformer-finding logic slightly. (Closed)

Created:
7 years, 2 months ago by nweiz

Modified:
7 years, 1 month ago

Reviewers:
Bob Nystrom, Alan Knight

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revise the barback transformer-finding logic slightly. If the user specifies a transformer named "package_name", pub will now prefer "lib/transformer.dart" (if it exists) to "lib/package_name.dart". BUG=13256 R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=29035

Patch Set 1 #

Total comments: 4

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+134 lines, -111 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback.dart	View	3 chunks	+54 lines, -48 lines	4 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart	View	6 chunks	+20 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart	View	1 chunk	+33 lines, -29 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/pubspec.dart	View	1 chunk	+16 lines, -15 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/transformer/prefers_transformer_to_library_name_test.dart	View	4 chunks	+11 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 manually as r29035 (presubmit successful).

7 years, 2 months ago (2013-10-22 20:43:15 UTC) #3

Bob Nystrom

Nits, but LGTM. https://codereview.chromium.org/29603004/diff/1/sdk/lib/_internal/pub/lib/src/barback.dart File sdk/lib/_internal/pub/lib/src/barback.dart (right): https://codereview.chromium.org/29603004/diff/1/sdk/lib/_internal/pub/lib/src/barback.dart#newcode26 sdk/lib/_internal/pub/lib/src/barback.dart:26: /// The package containing the library ...

7 years, 1 month ago (2013-10-28 17:24:24 UTC) #4

nweiz

7 years, 1 month ago (2013-10-28 23:58:05 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/29603004/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/barback.dart (right):

https://codereview.chromium.org/29603004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback.dart:26: /// The package containing the
library that this transformer identifies.
On 2013/10/28 17:24:25, Bob Nystrom wrote:
> "this transformer identifies" is confusing. How about "The package containing
> the library where the transformer is defined"?

Done.

https://codereview.chromium.org/29603004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback.dart:29: /// The `/`-separated path
identifying the library that contains this
On 2013/10/28 17:24:25, Bob Nystrom wrote:
> "identifying" -> "to"

Done.

Expand Messages | Collapse Messages