Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 295863002: Write barrier audit, part 1 (Closed)

Created:
6 years, 7 months ago by koda
Modified:
6 years, 2 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Write barrier audit, part 1. First step towards complete audit of all writes to the heap for write barrier compliance (at least on simulator debug builds). This first CL is a semi-mechanical refactoring to route most Object field writes through StoreNonPointer and StoreSmi methods. A few stores were converted to StorePointer (skipping the write barrier check is premature optimization for those cases). Next step will be to make raw_ptr() return a const pointer and use the constness to clean up remaining writes in C++. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=40889

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -119 lines) Patch
M runtime/vm/object.h View 1 2 3 4 5 6 7 8 9 36 chunks +85 lines, -47 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 45 chunks +81 lines, -72 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
6 years, 7 months ago (2014-05-20 06:49:18 UTC) #1
koda
6 years, 2 months ago (2014-10-01 19:33:49 UTC) #2
Ivan Posva
LGTM -ip
6 years, 2 months ago (2014-10-02 19:44:46 UTC) #3
koda
6 years, 2 months ago (2014-10-02 20:47:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #10 (id:180001) manually as r40889 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698