Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 29583004: Make AudioContext work in iOS 7. (Closed)

Created:
7 years, 2 months ago by Emily Fortuna
Modified:
7 years, 2 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make AudioContext work in iOS 7. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=28877

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rupload #

Patch Set 5 : upload again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +4 lines, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +4 lines, -1 line 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/generator.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Emily Fortuna
https://codereview.chromium.org/29583004/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/29583004/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode29050 sdk/lib/html/dart2js/html_dart2js.dart:29050: + * the set, otherwise `false`. spurious change (changes ...
7 years, 2 months ago (2013-10-18 20:09:29 UTC) #1
sra1
https://codereview.chromium.org/29583004/diff/1/sdk/lib/web_audio/dartium/web_audio_dartium.dart File sdk/lib/web_audio/dartium/web_audio_dartium.dart (right): https://codereview.chromium.org/29583004/diff/1/sdk/lib/web_audio/dartium/web_audio_dartium.dart#newcode267 sdk/lib/web_audio/dartium/web_audio_dartium.dart:267: class AudioContext extends EventTarget native "AudioContext,webkitAudioContext" { Should not ...
7 years, 2 months ago (2013-10-18 20:13:24 UTC) #2
Emily Fortuna
whoops. ptal.
7 years, 2 months ago (2013-10-18 20:22:19 UTC) #3
sra1
lgtm
7 years, 2 months ago (2013-10-18 20:34:54 UTC) #4
Emily Fortuna
7 years, 2 months ago (2013-10-18 20:37:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r28877 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698