Issue 295803003: Fix issue 18435.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295803003: Fix issue 18435. (Closed)

Created:
6 years, 7 months ago by regis

Modified:
6 years, 7 months ago

Reviewers:
srdjan, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue 18435. Add regression test. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=36362

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -1 line)			Patch
M	runtime/vm/parser.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/scopes.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/scopes.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	tests/language/regress_18435_test.dart	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	tests/language/regress_18865_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

Let me know if you can think of a cleaner fix. Thanks, Regis

6 years, 7 months ago (2014-05-19 23:45:48 UTC) #1

hausner

I can't think of a cleaner fix at this point. Maybe we can discuss ITO ...

6 years, 7 months ago (2014-05-20 16:40:23 UTC) #2

regis

Committed patchset #1 manually as r36362 (presubmit successful).

6 years, 7 months ago (2014-05-20 16:41:41 UTC) #3

regis

6 years, 7 months ago (2014-05-20 16:42:18 UTC) #4

Message was sent while issue was closed.

On 2014/05/20 16:40:23, hausner wrote:
> I can't think of a cleaner fix at this point. Maybe we can discuss ITO
tomorrow.
> 
> LGTM.

Sounds good. Thanks.

Expand Messages | Collapse Messages