Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2950883002: Change '127.0.0.1' to 'localhost' to support both IPv4 and IPv6 envs. (Closed)

Created:
3 years, 6 months ago by keertip
Modified:
3 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change '127.0.0.1' to 'localhost' to support both IPv4 and IPv6 envs. BUG= R=nweiz@google.com Committed: https://github.com/dart-lang/http_multi_server/commit/b62a7106ba4c15f38587bd3055deaef31f85f0a8

Patch Set 1 #

Patch Set 2 : change pubspec version to dev #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/http_multi_server_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
keertip
3 years, 6 months ago (2017-06-20 16:59:18 UTC) #2
nweiz
Can you bump the pubspec version to 2.0.4-dev as well?
3 years, 6 months ago (2017-06-20 21:24:55 UTC) #3
keertip
On 2017/06/20 21:24:55, nweiz wrote: > Can you bump the pubspec version to 2.0.4-dev as ...
3 years, 6 months ago (2017-06-20 22:39:21 UTC) #4
nweiz
lgtm
3 years, 6 months ago (2017-06-20 22:50:13 UTC) #5
keertip
3 years, 6 months ago (2017-06-21 16:25:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b62a7106ba4c15f38587bd3055deaef31f85f0a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698