Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 294993002: patch from issue 294853002 (Closed)

Created:
6 years, 7 months ago by Jacob
Modified:
6 years, 7 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : #

Patch Set 4 : Ready to review #

Patch Set 5 : ready #

Patch Set 6 : #

Patch Set 7 : ptal #

Patch Set 8 : ptal #

Patch Set 9 : ptal #

Patch Set 10 : Set of native fixes #

Patch Set 11 : ptal #

Patch Set 12 : eady to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -120 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 2 3 4 5 6 7 8 9 10 11 20 chunks +63 lines, -78 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +1 line, -25 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +25 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 2 3 4 5 6 7 8 9 10 11 10 chunks +27 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jacob
Large number of binding generation fixes. There is a matching blink fix.
6 years, 7 months ago (2014-05-20 21:57:08 UTC) #1
Leaf
lgtm
6 years, 7 months ago (2014-05-20 22:14:17 UTC) #2
Jacob
6 years, 7 months ago (2014-05-20 22:21:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #12 manually as r36395 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698