Issue 294943008: - Landing https://codereview.chromium.org/293963008/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 294943008: - Landing https://codereview.chromium.org/293963008/ (Closed)

Created:
6 years, 7 months ago by Ivan Posva

Modified:
6 years, 7 months ago

Reviewers:
Cutch, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -65 lines)			Patch
M	runtime/lib/mirrors.cc	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1	7 chunks	+20 lines, -16 lines	0 comments	Download
M	runtime/vm/compiler.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/compiler.cc	View	1	8 chunks	+21 lines, -14 lines	0 comments	Download
M	runtime/vm/coverage.cc	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_entry.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1	6 chunks	+9 lines, -7 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1	7 chunks	+19 lines, -17 lines	0 comments	Download
M	runtime/vm/tags.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/unit_test.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Ivan Posva

Committed patchset #2 manually as r36451 (presubmit successful).

6 years, 7 months ago (2014-05-21 21:04:16 UTC) #2

Message was sent while issue was closed.