Issue 294643006: Roll back explicit cross frame object until M35 lands

Issue 294643006: Roll back explicit cross frame object until M35 lands (Closed)

Created:
6 years, 7 months ago by Leaf

Modified:
6 years, 7 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Roll back explicit cross frame object until M35 lands BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=36323

Patch Set 2 : Remove commented out lines #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -26 lines)			Patch
	M	sdk/lib/_blink/dartium/_blink_dartium.dart	View	1	1 chunk	+13 lines, -13 lines	0 comments	Download
	M	tools/dom/src/blink_native_DOMImplementation.dart	View	1	1 chunk	+13 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jacob

https://codereview.chromium.org/294643006/diff/1/sdk/lib/_blink/dartium/_blink_dartium.dart File sdk/lib/_blink/dartium/_blink_dartium.dart (right): https://codereview.chromium.org/294643006/diff/1/sdk/lib/_blink/dartium/_blink_dartium.dart#newcode8325 sdk/lib/_blink/dartium/_blink_dartium.dart:8325: // Native_DOMWindowCrossFrame_get_history(_DOMWindowCrossFrame) native "WindowCrossFrame_history_Getter"; don't check in commented out ...

6 years, 7 months ago (2014-05-19 20:49:33 UTC) #2

Leaf

6 years, 7 months ago (2014-05-19 20:54:28 UTC) #3

Leaf

6 years, 7 months ago (2014-05-19 20:58:09 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r36323 (presubmit successful).

Expand Messages | Collapse Messages