Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 29463002: fix for Set.add tweak in r28863 (Closed)

Created:
7 years, 2 months ago by kevmoo-old
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix for barback #

Patch Set 3 : again #

Patch Set 4 : fixes for bool return value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M pkg/barback/test/utils.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M pkg/unmodifiable_collection/lib/unmodifiable_collection.dart View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo-old
See the build break...on it This is the first of a couple of things for ...
7 years, 2 months ago (2013-10-18 17:38:41 UTC) #1
kevmoo-old
PTAL
7 years, 2 months ago (2013-10-18 17:47:43 UTC) #2
blois
lgtm
7 years, 2 months ago (2013-10-18 17:53:02 UTC) #3
kevmoo-old
7 years, 2 months ago (2013-10-18 17:54:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r28866 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698