Issue 294473006: Disallow eval on lists containing non-instances.

Issue 294473006: Disallow eval on lists containing non-instances. (Closed)

Created:
6 years, 7 months ago by koda

Modified:
6 years, 7 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Disallow eval on lists containing non-instances. BUG=dart:18781 R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=36435

Patch Set 2 : #

Total comments: 4

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -0 lines)			Patch
	M	runtime/vm/service.cc	View		2 chunks	+21 lines, -0 lines	4 comments	Download
	M	runtime/vm/service_test.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

turnidge

lgtm w/ comments. https://codereview.chromium.org/294473006/diff/20001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/294473006/diff/20001/runtime/vm/service.cc#newcode854 runtime/vm/service.cc:854: static bool IsInternal(const Object& obj) { ...

6 years, 7 months ago (2014-05-20 23:21:34 UTC) #2

koda

https://codereview.chromium.org/294473006/diff/20001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/294473006/diff/20001/runtime/vm/service.cc#newcode854 runtime/vm/service.cc:854: static bool IsInternal(const Object& obj) { On 2014/05/20 23:21:34, ...

6 years, 7 months ago (2014-05-21 15:49:23 UTC) #3

koda

6 years, 7 months ago (2014-05-21 15:51:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r36435 (presubmit successful).

Expand Messages | Collapse Messages