Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 294293003: Allow delegate calls even though the target is not reflectable. (Closed)

Created:
6 years, 7 months ago by floitsch
Modified:
6 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow delegate calls even though the target is not reflectable. BUG= http://dartbug.com/15138 BUG= http://dartbug.com/17451 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=36621

Patch Set 1 #

Patch Set 2 : Move code and update tests. #

Patch Set 3 : Remove bad comment. #

Patch Set 4 : Revert unnecessary change. #

Patch Set 5 : TearoffClosure is superclass of BoundClosure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -31 lines) Patch
M sdk/lib/_internal/lib/js_helper.dart View 1 2 2 chunks +0 lines, -12 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 1 2 3 4 7 chunks +19 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_extra/inference_nsm_mirrors_test.dart View 1 1 chunk +4 lines, -1 line 0 comments Download
M tests/lib/lib.status View 2 chunks +0 lines, -4 lines 0 comments Download
M tests/lib/mirrors/invoke_call_through_getter_previously_accessed_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/lib/mirrors/invoke_call_through_getter_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/lib/mirrors/invoke_call_through_implicit_getter_previously_accessed_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
6 years, 7 months ago (2014-05-23 21:06:33 UTC) #1
karlklose
LGTM.
6 years, 7 months ago (2014-05-26 08:15:20 UTC) #2
floitsch
6 years, 7 months ago (2014-05-26 08:56:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r36621 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698