Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 294193003: Fix thread-interrupter shutdown on Windows. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix thread-interrupter shutdown on Windows. This reworks the ThreadId on Windows to be the tid, and not an open HANDLE. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36502

Patch Set 1 #

Patch Set 2 : Cleanup based on typedef fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -75 lines) Patch
M runtime/platform/thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/platform/thread_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/platform/thread_linux.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/platform/thread_macos.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/platform/thread_win.h View 3 chunks +1 line, -5 lines 0 comments Download
M runtime/platform/thread_win.cc View 1 5 chunks +22 lines, -42 lines 0 comments Download
M runtime/vm/os_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/profiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/thread_interrupter.cc View 2 chunks +17 lines, -14 lines 0 comments Download
M runtime/vm/thread_interrupter_win.cc View 1 2 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 7 months ago (2014-05-22 15:08:21 UTC) #1
Cutch
lgtm
6 years, 7 months ago (2014-05-22 15:10:57 UTC) #2
Anders Johnsen
6 years, 7 months ago (2014-05-22 15:12:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r36502 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698