Issue 294163011: dart2dart: Fix fallthrough in while statements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 294163011: dart2dart: Fix fallthrough in while statements. (Closed)

Created:
6 years, 7 months ago by asgerf

Modified:
6 years, 7 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -0 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	A	tests/language/rewrite_while_test.dart	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

asgerf

Only includes a bugfix. Continue statements are not yet eliminated by fallthrough, but break statements ...

6 years, 7 months ago (2014-05-23 11:43:37 UTC) #1

asgerf

6 years, 7 months ago (2014-05-23 12:38:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r36566 (presubmit successful).