Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 294043009: Revert "Revert 2 CLs to get one last Dartium 34." (Closed)

Created:
6 years, 7 months ago by vsm
Modified:
6 years, 7 months ago
Reviewers:
ricow1, Jacob
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Revert "Revert 2 CLs to get one last Dartium 34." This reapplies Jacob's CLs for Dartium 35 / 1916. For landing after: https://codereview.chromium.org/298823004/ R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=36419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -131 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 21 chunks +74 lines, -89 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +1 line, -25 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 4 chunks +25 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 10 chunks +28 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
6 years, 7 months ago (2014-05-21 11:11:00 UTC) #1
ricow1
lgtm
6 years, 7 months ago (2014-05-21 11:11:26 UTC) #2
vsm
6 years, 7 months ago (2014-05-21 11:13:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36419 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698