Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 29343004: Support all Transform methods on ForeignTransform. (Closed)

Created:
7 years, 2 months ago by nweiz
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Support all Transform methods on ForeignTransform. R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=28895

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -23 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart View 1 3 chunks +27 lines, -2 lines 0 comments Download
A + sdk/lib/_internal/pub/test/transformer/can_use_read_input_as_string_test.dart View 3 chunks +13 lines, -10 lines 0 comments Download
A + sdk/lib/_internal/pub/test/transformer/can_use_read_input_test.dart View 3 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
7 years, 2 months ago (2013-10-18 22:15:57 UTC) #1
Alan Knight
lgtm https://codereview.chromium.org/29343004/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart File sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart (right): https://codereview.chromium.org/29343004/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart#newcode23 sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart:23: /// marhsals calls to and from them with ...
7 years, 2 months ago (2013-10-18 22:45:55 UTC) #2
nweiz
https://codereview.chromium.org/29343004/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart File sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart (right): https://codereview.chromium.org/29343004/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart#newcode23 sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart:23: /// marhsals calls to and from them with the ...
7 years, 2 months ago (2013-10-18 23:00:52 UTC) #3
nweiz
Committed patchset #2 manually as r28895 (presubmit successful).
7 years, 2 months ago (2013-10-18 23:01:08 UTC) #4
Bob Nystrom
7 years, 1 month ago (2013-10-26 00:08:55 UTC) #5
Message was sent while issue was closed.
LGTM!

Powered by Google App Engine
This is Rietveld 408576698