Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 293393005: Make methods on isolate external. (Closed)

Created:
6 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva, floitsch
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -68 lines) Patch
M runtime/lib/isolate_patch.dart View 1 chunk +36 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/isolate_patch.dart View 1 chunk +65 lines, -0 lines 0 comments Download
M sdk/lib/isolate/isolate.dart View 9 chunks +18 lines, -55 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
6 years, 7 months ago (2014-05-26 14:28:19 UTC) #1
Søren Gjesse
lgtm
6 years, 7 months ago (2014-05-26 15:20:42 UTC) #2
Ivan Posva
LGTM -ip
6 years, 7 months ago (2014-05-26 15:23:26 UTC) #3
Lasse Reichstein Nielsen
6 years, 7 months ago (2014-05-27 06:14:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r36642 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698