Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 293363007: Add 'Sockets' to observatory. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Deploy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2363 lines, -1678 lines) Patch
M runtime/bin/service_object_patch.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html View 1 3 chunks +265 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 221 chunks +865 lines, -836 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 3 chunks +265 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 1 221 chunks +865 lines, -836 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/io_view.html View 1 3 chunks +39 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/io_view.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/io_view.html View 3 chunks +39 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_view.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
6 years, 7 months ago (2014-05-27 07:31:15 UTC) #1
Cutch
lgtm
6 years, 7 months ago (2014-05-27 07:43:36 UTC) #2
Anders Johnsen
Deploy
6 years, 7 months ago (2014-05-27 07:49:34 UTC) #3
Anders Johnsen
6 years, 7 months ago (2014-05-27 07:50:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r36650 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698