Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 29323004: Make stack frames without columns print correctly. (Closed)

Created:
7 years, 2 months ago by nweiz
Modified:
7 years, 2 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make stack frames without columns print correctly. This works around issue 14233. R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=28884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M pkg/stack_trace/lib/src/frame.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/stack_trace/test/frame_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 2 months ago (2013-10-18 18:56:41 UTC) #1
Alan Knight
lgtm
7 years, 2 months ago (2013-10-18 20:57:48 UTC) #2
nweiz
7 years, 2 months ago (2013-10-18 21:55:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28884 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698