Issue 293133003: Emit intrinsified code even if optimization is turned off.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293133003: Emit intrinsified code even if optimization is turned off. (Closed)

Created:
6 years, 7 months ago by srdjan

Modified:
6 years, 7 months ago

Reviewers:
zra, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Emit intrinsified code even if optimziation is turned off. Also remove unsued flag —report-usage. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=36529

Patch Set 2 : #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -11 lines)			Patch
M	runtime/vm/code_generator.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1	3 chunks	+1 line, -4 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1	2 chunks	+1 line, -6 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/293133003/diff/20001/runtime/vm/isolate.cc File runtime/vm/isolate.cc (left): https://codereview.chromium.org/293133003/diff/20001/runtime/vm/isolate.cc#oldcode768 runtime/vm/isolate.cc:768: PrintInvokedFunctions(); This is the only call. Please ...

6 years, 7 months ago (2014-05-22 21:15:37 UTC) #3

srdjan

6 years, 7 months ago (2014-05-22 21:30:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r36529 (presubmit successful).

Expand Messages | Collapse Messages

Issue 293133003: Emit intrinsified code even if optimization is turned off. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages