Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 29313003: Don't evaluate << because of possible overflow. (Closed)

Created:
7 years, 2 months ago by scheglov
Modified:
7 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't evaluate << because of possible overflow. Applied same change to Dart version to fix crash. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=28873

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 2 months ago (2013-10-18 19:27:00 UTC) #1
Brian Wilkerson
LGTM
7 years, 2 months ago (2013-10-18 19:36:15 UTC) #2
scheglov
7 years, 2 months ago (2013-10-18 19:38:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28873 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698