Issue 293013003: Fix archive uploader bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293013003: Fix archive uploader bug. (Closed)

Created:
6 years, 7 months ago by Bill Hesse

Modified:
6 years, 7 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix archive uploader bug. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=36410

Patch Set 1 #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	tools/dartium/multivm_archive.py	View		1 chunk	+1 line, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

lgtm, but why do we need this https://codereview.chromium.org/293013003/diff/1/tools/dartium/multivm_archive.py File tools/dartium/multivm_archive.py (right): https://codereview.chromium.org/293013003/diff/1/tools/dartium/multivm_archive.py#newcode31 tools/dartium/multivm_archive.py:31: shell=(platform.system() == ...

6 years, 7 months ago (2014-05-21 07:47:06 UTC) #2

Bill Hesse

https://codereview.chromium.org/293013003/diff/1/tools/dartium/multivm_archive.py File tools/dartium/multivm_archive.py (right): https://codereview.chromium.org/293013003/diff/1/tools/dartium/multivm_archive.py#newcode31 tools/dartium/multivm_archive.py:31: shell=(platform.system() == 'Windows'), On 2014/05/21 07:47:06, ricow1 wrote: > ...

6 years, 7 months ago (2014-05-21 08:18:39 UTC) #3

Bill Hesse

6 years, 7 months ago (2014-05-21 08:41:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r36410 (presubmit successful).

Expand Messages | Collapse Messages