Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 292983002: Clean up mime package. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clean up mime package. Also speed up default mime-type map, by not using a const map. BUG= R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=36543

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M pkg/mime/lib/src/default_extension_map.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/mime/lib/src/magic_number.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/mime/lib/src/mime_type.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/mime/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
This change should not be breaking. Perf example: import 'package:mime/mime.dart'; void main() { for (int ...
6 years, 7 months ago (2014-05-20 08:01:48 UTC) #1
kevmoo
LGTM w/ a note about a TODO https://codereview.chromium.org/292983002/diff/1/pkg/mime/lib/src/default_extension_map.dart File pkg/mime/lib/src/default_extension_map.dart (right): https://codereview.chromium.org/292983002/diff/1/pkg/mime/lib/src/default_extension_map.dart#newcode8 pkg/mime/lib/src/default_extension_map.dart:8: final Map<String, ...
6 years, 7 months ago (2014-05-20 18:55:05 UTC) #2
Anders Johnsen
https://codereview.chromium.org/292983002/diff/1/pkg/mime/lib/src/default_extension_map.dart File pkg/mime/lib/src/default_extension_map.dart (right): https://codereview.chromium.org/292983002/diff/1/pkg/mime/lib/src/default_extension_map.dart#newcode8 pkg/mime/lib/src/default_extension_map.dart:8: final Map<String, String> defaultExtensionMap = <String, String>{ On 2014/05/20 ...
6 years, 7 months ago (2014-05-23 07:07:06 UTC) #3
Anders Johnsen
6 years, 7 months ago (2014-05-23 07:07:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r36543 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698