Fix issue 12654

Fix issue 12654

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28864

[scheglov, 2013-10-18 17:00:15]

https://codereview.chromium.org/29283003/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/29283003/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:4915:
|| (callMethod instanceof MethodElement && ((MethodElement)
callMethod).isAbstract())) {
What if there is getter "call"?

[Brian Wilkerson, 2013-10-18 17:04:03]

https://codereview.chromium.org/29283003/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/29283003/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:4915:
|| (callMethod instanceof MethodElement && ((MethodElement)
callMethod).isAbstract())) {
> What if there is getter "call"?

The specification states: "It is a static warning if a concrete class implements
Function and does not have a concrete method named call().". I don't think we
support using a getter named call.

[scheglov, 2013-10-18 17:10:38]

https://codereview.chromium.org/29283003/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/29283003/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:4915:
|| (callMethod instanceof MethodElement && ((MethodElement)
callMethod).isAbstract())) {
On 2013/10/18 17:04:03, Brian Wilkerson wrote:
> > What if there is getter "call"?
> 
> The specification states: "It is a static warning if a concrete class
implements
> Function and does not have a concrete method named call().". I don't think we
> support using a getter named call.

So, it should be method, so as I understand we need to report warning if we
found getter "call".
It doesn't look like we are doing this here.

[Brian Wilkerson, 2013-10-18 17:27:01]

PTAL

[scheglov, 2013-10-18 17:30:19]

lgtm

Would be great to have a test for getter though.

[Brian Wilkerson, 2013-10-18 17:37:56]

Committed patchset #2 manually as r28864 (presubmit successful).