CanvasRenderingContext2D.fillText now works correctly with null maxWidth.

CanvasRenderingContext2D.fillText now works correctly with null maxWidth.

BUG=13369
R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28963

[Andrei Mouravski, 2013-10-18 21:45:26]

I think this works fine, but I'm just double checking.

[Andrei Mouravski, 2013-10-19 00:20:17]

Somehow missed the button.

[Emily Fortuna, 2013-10-19 00:29:45]

https://codereview.chromium.org/29273005/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate
(right):

https://codereview.chromium.org/29273005/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate:284:
void fillText(String text, num x, num y, [num maxWidth]) {
how about instead write this function this way:

$if DART2JS
void fillText(String text, num x, num y, [num maxWidth]) {
   if (maxWidth != null) {
      JS('void', '#.fillText(#, #, #, #)', this, text, x, y, maxWidth);
   } else {
      JS('void', '#.fillText(#, #, #)', this, text, x, y);
   }
}
$endif 

and then put "fillText" in the js_custom_methods in system_html.py

[Andrei Mouravski, 2013-10-21 19:39:09]

PTAL.

https://codereview.chromium.org/29273005/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate
(right):

https://codereview.chromium.org/29273005/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate:284:
void fillText(String text, num x, num y, [num maxWidth]) {
On 2013/10/19 00:29:46, Emily Fortuna wrote:
> how about instead write this function this way:
> 
> $if DART2JS
> void fillText(String text, num x, num y, [num maxWidth]) {
>    if (maxWidth != null) {
>       JS('void', '#.fillText(#, #, #, #)', this, text, x, y, maxWidth);
>    } else {
>       JS('void', '#.fillText(#, #, #)', this, text, x, y);
>    }
> }
> $endif 
> 
> and then put "fillText" in the js_custom_methods in system_html.py

Done.

[Emily Fortuna, 2013-10-21 19:53:32]

https://codereview.chromium.org/29273005/diff/60001/tools/dom/templates/html/...
File tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate
(right):

https://codereview.chromium.org/29273005/diff/60001/tools/dom/templates/html/...
tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate:284:
$if DART2JS
put the docs inside the $if DART2JS clause. Otherwise you just have these
floating docs that connect to nothing in dartium

[Andrei Mouravski, 2013-10-21 20:54:39]

PTAL

https://codereview.chromium.org/29273005/diff/60001/tools/dom/templates/html/...
File tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate
(right):

https://codereview.chromium.org/29273005/diff/60001/tools/dom/templates/html/...
tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate:284:
$if DART2JS
On 2013/10/21 19:53:32, Emily Fortuna wrote:
> put the docs inside the $if DART2JS clause. Otherwise you just have these
> floating docs that connect to nothing in dartium

Done.

[Emily Fortuna, 2013-10-21 21:31:24]

https://codereview.chromium.org/29273005/diff/120001/sdk/lib/html/dartium/htm...
File sdk/lib/html/dartium/html_dartium.dart (left):

https://codereview.chromium.org/29273005/diff/120001/sdk/lib/html/dartium/htm...
sdk/lib/html/dartium/html_dartium.dart:35646: -  // DOM node rather than just a
class that extends Node.
what's with these changes? Does running go.sh on master also produce these
changes?

[Emily Fortuna, 2013-10-21 22:04:15]

lgtm

[Andrei Mouravski, 2013-10-21 22:09:14]

Committed patchset #8 manually as r28963 (presubmit successful).