Remove uses of IterableMixinWorkaround outside of VM and dart2js lists.

Remove uses of IterableMixinWorkaround outside of VM and dart2js lists.

Remaining uses are in:

- array.dart (VM)
- growable_array.dart (VM)
- typed_data.dart (VM)
- js_array.dart (Dart2js)

These need support from the VM and dart2js teams to remove.

R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36553

[Søren Gjesse, 2014-05-23 07:18:12]

lgtm

https://codereview.chromium.org/292323006/diff/1/tests/corelib/collection_to_...
File tests/corelib/collection_to_string_test.dart (right):

https://codereview.chromium.org/292323006/diff/1/tests/corelib/collection_to_...
tests/corelib/collection_to_string_test.dart:90: print("Expect: $expected");
Debug print.

[Lasse Reichstein Nielsen, 2014-05-23 09:09:52]

https://codereview.chromium.org/292323006/diff/1/tests/corelib/collection_to_...
File tests/corelib/collection_to_string_test.dart (right):

https://codereview.chromium.org/292323006/diff/1/tests/corelib/collection_to_...
tests/corelib/collection_to_string_test.dart:90: print("Expect: $expected");
Not really, they were already in the test, I just added "Expect:" and "Actual"
in front.

[Lasse Reichstein Nielsen, 2014-05-23 09:39:19]

Committed patchset #1 manually as r36553 (presubmit successful).

[floitsch, 2014-05-23 10:24:54]

https://codereview.chromium.org/292323006/diff/1/sdk/lib/collection/iterable....
File sdk/lib/collection/iterable.dart (right):

https://codereview.chromium.org/292323006/diff/1/sdk/lib/collection/iterable....
sdk/lib/collection/iterable.dart:411: String _setToString(Set set) =>
_collectionToString(set, "{" , "}");
This is not the same as `IterableMixinWorkaround.toStringIterable(this, '{',
'}');`

The IterableMixinWorkaround.toStringIterable was not shortening.

[Lasse Reichstein Nielsen, 2014-05-23 11:46:47]

https://codereview.chromium.org/292323006/diff/1/sdk/lib/collection/iterable....
File sdk/lib/collection/iterable.dart (right):

https://codereview.chromium.org/292323006/diff/1/sdk/lib/collection/iterable....
sdk/lib/collection/iterable.dart:411: String _setToString(Set set) =>
_collectionToString(set, "{" , "}");
I know, and I think it should be shortened if it is too long.
I'd do the same for List.

[floitsch, 2014-05-23 11:53:57]

https://codereview.chromium.org/292323006/diff/1/sdk/lib/collection/iterable....
File sdk/lib/collection/iterable.dart (right):

https://codereview.chromium.org/292323006/diff/1/sdk/lib/collection/iterable....
sdk/lib/collection/iterable.dart:411: String _setToString(Set set) =>
_collectionToString(set, "{" , "}");
On 2014/05/23 11:46:48, Lasse Reichstein Nielsen wrote:
> I know, and I think it should be shortened if it is too long.
> I'd do the same for List.

That's a breaking change. I can easily imagine doing a print(list) instead of
going through JSON.encode when I know that the list only contains numbers.

Similarly, users may use the output of sets.