Issue 291923004: Fix issue 18865.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291923004: Fix issue 18865. (Closed)

Created:
6 years, 7 months ago by regis

Modified:
6 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue 18865. Add regression test. Committed: https://code.google.com/p/dart/source/detail?r=36307

Patch Set 1 #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
	M	runtime/vm/object.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	A	tests/language/regress_18865_test.dart	View		1 chunk	+15 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

Committed patchset #1 manually as r36307 (presubmit successful).

6 years, 7 months ago (2014-05-19 17:31:17 UTC) #2

srdjan

lgtm https://codereview.chromium.org/291923004/diff/1/tests/language/regress_18865_test.dart File tests/language/regress_18865_test.dart (right): https://codereview.chromium.org/291923004/diff/1/tests/language/regress_18865_test.dart#newcode14 tests/language/regress_18865_test.dart:14: A.foo(); indentation

6 years, 7 months ago (2014-05-19 17:38:14 UTC) #3

regis

6 years, 7 months ago (2014-05-19 17:46:31 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/291923004/diff/1/tests/language/regress_18865...
File tests/language/regress_18865_test.dart (right):

https://codereview.chromium.org/291923004/diff/1/tests/language/regress_18865...
tests/language/regress_18865_test.dart:14: A.foo();
On 2014/05/19 17:38:14, srdjan wrote:
> indentation

Thanks! I'll fix it in a future cl.

Expand Messages | Collapse Messages