Issue 291343009: Add initial Random Access File information to Observatory

Issue 291343009: Add initial Random Access File information to Observatory (Closed)

Created:
6 years, 7 months ago by Cutch

Modified:
6 years, 7 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add initial Random Access File information to Observatory BUG= R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=36638

Patch Set 3 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2854 lines, -861 lines)			Patch
M	runtime/bin/service_object_patch.dart	View		2 chunks	+20 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1 2	2 chunks	+756 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View	1 2	97 chunks	+534 lines, -429 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html	View	1 2	2 chunks	+756 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View	1 2	97 chunks	+534 lines, -429 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/io_view.html	View	1 2	2 chunks	+78 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/io_view.dart	View		1 chunk	+52 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/io_view.html	View	1	2 chunks	+78 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/service_view.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	1	2 chunks	+36 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM /w comments! Sorry for the slow review. https://codereview.chromium.org/291343009/diff/1/runtime/bin/vmservice/client/lib/src/elements/io_view.dart File runtime/bin/vmservice/client/lib/src/elements/io_view.dart (right): https://codereview.chromium.org/291343009/diff/1/runtime/bin/vmservice/client/lib/src/elements/io_view.dart#newcode103 runtime/bin/vmservice/client/lib/src/elements/io_view.dart:103: void ...

6 years, 7 months ago (2014-05-25 17:59:23 UTC) #2

Cutch

https://codereview.chromium.org/291343009/diff/1/runtime/bin/vmservice/client/lib/src/elements/io_view.dart File runtime/bin/vmservice/client/lib/src/elements/io_view.dart (right): https://codereview.chromium.org/291343009/diff/1/runtime/bin/vmservice/client/lib/src/elements/io_view.dart#newcode103 runtime/bin/vmservice/client/lib/src/elements/io_view.dart:103: void _updateFile() { On 2014/05/25 17:59:23, Anders Johnsen wrote: ...

6 years, 7 months ago (2014-05-26 15:32:17 UTC) #3

Cutch

6 years, 7 months ago (2014-05-26 15:34:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r36638 (presubmit successful).

Expand Messages | Collapse Messages