Issue 291303006: Fix issue 18646.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291303006: Fix issue 18646. (Closed)

Created:
6 years, 7 months ago by regis

Modified:
6 years, 7 months ago

Reviewers:
hausner, Jacob

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Jacob

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	runtime/vm/object.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

hausner

lgtm. The test may not be necessary. Jacob had a unit test that triggered the ...

6 years, 7 months ago (2014-05-21 20:15:16 UTC) #2

regis

Thanks Matthias. I removed the regression test and I am counting on Jacob to submit ...

6 years, 7 months ago (2014-05-21 20:26:46 UTC) #3

regis

6 years, 7 months ago (2014-05-21 20:27:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r36448 (presubmit successful).