Add multivm archive download script for buildbot use.

Add multivm archive download script for buildbot use.

BUG=
R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36513

[ricow1, 2014-05-22 12:40:18]

https://codereview.chromium.org/291153010/diff/40001/tools/dartium/download_m...
File tools/dartium/download_multivm.py (right):

https://codereview.chromium.org/291153010/diff/40001/tools/dartium/download_m...
tools/dartium/download_multivm.py:3: # Copyright (c) 2014 The Chromium Authors.
All rights reserved.
use dart copyright notice?

https://codereview.chromium.org/291153010/diff/40001/tools/dartium/download_m...
tools/dartium/download_multivm.py:72: print 'Executing: ' + ' '.join(cmd)
I suggest that we just use
subprocess.check_output
instead.

That will eliminate most of this function, and you can remove all of the if
status above.

[Bill Hesse, 2014-05-22 12:59:37]

Addressed comments.  Much better.  PTAL.

https://codereview.chromium.org/291153010/diff/40001/tools/dartium/download_m...
File tools/dartium/download_multivm.py (right):

https://codereview.chromium.org/291153010/diff/40001/tools/dartium/download_m...
tools/dartium/download_multivm.py:3: # Copyright (c) 2014 The Chromium Authors.
All rights reserved.
On 2014/05/22 12:40:19, ricow1 wrote:
> use dart copyright notice?

Done.

https://codereview.chromium.org/291153010/diff/40001/tools/dartium/download_m...
tools/dartium/download_multivm.py:72: print 'Executing: ' + ' '.join(cmd)
On 2014/05/22 12:40:19, ricow1 wrote:
> I suggest that we just use
> subprocess.check_output
> instead.
> 
> That will eliminate most of this function, and you can remove all of the if
> status above.

Done.

[ricow1, 2014-05-22 13:18:10]

lgtm

https://codereview.chromium.org/291153010/diff/80001/tools/dartium/download_m...
File tools/dartium/download_multivm.py (right):

https://codereview.chromium.org/291153010/diff/80001/tools/dartium/download_m...
tools/dartium/download_multivm.py:20: if platform.system() == 'Windows':
if we are not on a bot we should default to just gsutil and use the system
supplied one

https://codereview.chromium.org/291153010/diff/80001/tools/dartium/download_m...
tools/dartium/download_multivm.py:24: GSUTIL =
'/usr/local/google/home/whesse/ssd/gsutil/gsutil'
I don't think you want to do that :-)

https://codereview.chromium.org/291153010/diff/80001/tools/dartium/download_m...
tools/dartium/download_multivm.py:36: dartium_archive = dartium_bucket + '-' +
revision + '.zip'
dartium_archive -> filename

https://codereview.chromium.org/291153010/diff/80001/tools/dartium/download_m...
tools/dartium/download_multivm.py:71: bucket =
os.environ[BUILDER_NAME].replace('linux', 'lucid64')
do all the renaming here, remove from DownloadArchive

[Bill Hesse, 2014-05-22 16:23:41]

https://codereview.chromium.org/291153010/diff/80001/tools/dartium/download_m...
File tools/dartium/download_multivm.py (right):

https://codereview.chromium.org/291153010/diff/80001/tools/dartium/download_m...
tools/dartium/download_multivm.py:20: if platform.system() == 'Windows':
On 2014/05/22 13:18:11, ricow1 wrote:
> if we are not on a bot we should default to just gsutil and use the system
> supplied one

Done.  But we will fail earlier if BUILDBOT_BUILDERNAME is not in the
environment.

https://codereview.chromium.org/291153010/diff/80001/tools/dartium/download_m...
tools/dartium/download_multivm.py:24: GSUTIL =
'/usr/local/google/home/whesse/ssd/gsutil/gsutil'
On 2014/05/22 13:18:11, ricow1 wrote:
> I don't think you want to do that :-)

Done.

https://codereview.chromium.org/291153010/diff/80001/tools/dartium/download_m...
tools/dartium/download_multivm.py:36: dartium_archive = dartium_bucket + '-' +
revision + '.zip'
On 2014/05/22 13:18:11, ricow1 wrote:
> dartium_archive -> filename

archive_file

https://codereview.chromium.org/291153010/diff/80001/tools/dartium/download_m...
tools/dartium/download_multivm.py:71: bucket =
os.environ[BUILDER_NAME].replace('linux', 'lucid64')
On 2014/05/22 13:18:11, ricow1 wrote:
> do all the renaming here, remove from DownloadArchive

Done.

[ricow1, 2014-05-22 17:17:19]

lgtm

[Bill Hesse, 2014-05-22 17:21:22]

Committed patchset #7 manually as r36513 (presubmit successful).